Fix false positive in derive_hash_xor_eq #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems |
JohnTitor
added
the
S-waiting-on-author
This fixes a false positive in derive_hash_xor_eq where the lint was triggering on user-defined traits called `Hash`.
phansch
force-pushed
the
fix_fp_in_derive_hash_xor_eq
branch
from
13e3caf to
78b7e85
Compare
|
Yup, forgot to commit the updated .stderr file. |
phansch
added
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 78b7e85 has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 23, 2019
…, r=flip1995 Fix false positive in derive_hash_xor_eq This fixes a false positive in derive_hash_xor_eq where the lint was triggering on user-defined traits called `Hash`. changelog: Fix false positive in `derive_hash_xor_eq` Fixes rust-lang#4658
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 6 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4764 (Allow casts from the result of `checked_abs` to unsigned) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost changelog: none
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 23, 2019
…, r=flip1995 Fix false positive in derive_hash_xor_eq This fixes a false positive in derive_hash_xor_eq where the lint was triggering on user-defined traits called `Hash`. changelog: Fix false positive in `derive_hash_xor_eq` Fixes rust-lang#4658
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 5 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 5 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called
Hash.changelog: Fix false positive in
derive_hash_xor_eqFixes #4658